Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freebsd: Correct the order of arguments to copyin() for Q_SETQUOTA #10344

Merged
merged 1 commit into from
May 19, 2020
Merged

freebsd: Correct the order of arguments to copyin() for Q_SETQUOTA #10344

merged 1 commit into from
May 19, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 18, 2020

Authored by: jhb jhb@FreeBSD.org
Sponsored by: DARPA
Differential Revision: https://reviews.freebsd.org/D24656
FreeBSD-commit: freebsd/freebsd-src@a431c09

Ported-by: Ryan Moeller ryan@iXsystems.com
Signed-off-by: Ryan Moeller ryan@iXsystems.com

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@bsdjhb
freebsd: Correct the order of arguments to copyin() for Q_SETQUOTA
13a78c7 
Authored by:	jhb <jhb@FreeBSD.org>
Sponsored by:	DARPA
Differential Revision:	https://reviews.freebsd.org/D24656
FreeBSD-commit:	freebsd/freebsd-src@a431c09

Ported-by:	Ryan Moeller <ryan@iXsystems.com>
Signed-off-by:	Ryan Moeller <ryan@iXsystems.com>
@ghost ghost added the Status: Code Review Needed Ready for review and testing label May 18, 2020
@ghost ghost requested a review from amotin May 18, 2020 19:07
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #10344 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10344      +/-   ##
==========================================
- Coverage   79.57%   79.55%   -0.03%     
==========================================
  Files         390      390              
  Lines      123350   123350              
==========================================
- Hits        98153    98125      -28     
- Misses      25197    25225      +28
Flag Coverage Δ
#kernel 79.92% <ø> (-0.05%) ⬇️
#user 65.54% <ø> (-0.73%) ⬇️
Impacted Files Coverage Δ
module/zfs/bpobj.c 86.86% <0.00%> (-4.29%) ⬇️
module/zfs/vdev_removal.c 94.36% <0.00%> (-2.65%) ⬇️
module/zfs/dsl_synctask.c 92.40% <0.00%> (-2.54%) ⬇️
module/zfs/vdev_raidz.c 91.06% <0.00%> (-2.40%) ⬇️
module/icp/api/kcf_mac.c 38.28% <0.00%> (-1.72%) ⬇️
module/zfs/metaslab.c 94.12% <0.00%> (-1.58%) ⬇️
module/zfs/vdev_indirect_mapping.c 97.10% <0.00%> (-1.45%) ⬇️
module/zfs/vdev_indirect.c 73.33% <0.00%> (-1.34%) ⬇️
module/os/linux/zfs/zfs_file_os.c 84.15% <0.00%> (-1.00%) ⬇️
lib/libzutil/os/linux/zutil_import_os.c 78.07% <0.00%> (-0.67%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b090d5...13a78c7. Read the comment docs.

@behlendorf behlendorf merged commit 7b0e390 into openzfs:master May 19, 2020
@ghost ghost deleted the setquota-copyin branch May 20, 2020 02:35
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
freebsd: Correct the order of arguments to copyin() for Q_SETQUOTA
366b1ca 
Sponsored by: DARPA
External-issue: https://reviews.freebsd.org/D24656
FreeBSD-commit: freebsd/freebsd-src@a431c09

Authored by: jhb <jhb@FreeBSD.org>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Ported-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#10344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @behlendorf @amotin @bsdjhb